-
Couldn't load subscription status.
- Fork 35
Add doctest to Emscripten conda environment #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doctest to Emscripten conda environment #529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 9 9
Lines 3618 3618
=======================================
Hits 2631 2631
Misses 987 987 🚀 New features to boost your workflow:
|
|
CppInterOp does not depend on doctest. Why do we need this? |
@vgvassilev Because xeus-cpp does, and once the automated Emscripten tests PR reference in the PR description is in, xeus-cpp will try and find doctest to link against for the tests (tests are on and build by default in the PR). We could in theory set the xeus-cpp tests to OFF by a cmake option, but by keeping them on we will be able to have another check that no changes to CppInterOp break the Emscripten build of xeus-cpp. |
|
I am not sure I completely understand that dependency. The CppInterOp tests and the xeus-cpp tests should be separate and independent from each other. If there is some required dependency then we have a problem. |
I can change this PR to turn off xeus-cpp tests regardless of what the default value of XEUS_CPP_BUILD_TESTS in xeus-cpp is, but something will need to be done in preparation for the PR mentioned in this PR description. If no change is made, the Emscripten build, and deploy workflow will break once its in. One thing to note is that the environment-wasm.yml file is only in this repo because of CppInterOps xeus-cpp-lite build. Nothing in that file is a dependency of CppInterOp. |
|
Now I think I understand. That’s a ci dependency. Okay I think the pr is good to go from my side. |
Would you like to wait for the automated wasm tests PR in xeus-cpp to go in first, or can this go on now? |
|
This can go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Description
Please include a summary of changes, motivation and context for this PR.
Once this PR in xeus-cpp compiler-research/xeus-cpp#277 is ready and merged, doctest will need to be added Emscripten conda environment in CppInterOp.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist