Fix GetFunctionSignature to work for FunctionTemplateDecls
#536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| clang::FunctionDecl* FD; | ||
|
|
||
| if (llvm::dyn_cast<FunctionDecl>(D)) |
Contributor
There was a problem hiding this comment.
warning: return value from dyn_cast<> not used [llvm-prefer-isa-or-dyn-cast-in-conditionals]
Suggested change
| if (llvm::dyn_cast<FunctionDecl>(D)) | |
| if (isa::dyn_cast<FunctionDecl>(D)) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
+ Coverage 72.71% 72.74% +0.02%
==========================================
Files 9 9
Lines 3618 3621 +3
==========================================
+ Hits 2631 2634 +3
Misses 987 987
🚀 New features to boost your workflow:
|
vgvassilev
approved these changes
Mar 24, 2025
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Lgtm, assuming the ci passes and we squash on merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.