Skip to content

Fix Evaluate tests for emscripten build #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Evaluate tests for emscripten build #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20df8c7
Fix Evaluate tests for emscripten build
anutosh491 Apr 1, 2025
a49d361
try with later version
anutosh491 Apr 1, 2025
d863430
Reverting previous commit
anutosh491 Apr 1, 2025
37fa886
Update CMakeLists.txt
anutosh491 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions unittests/CppInterOp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ else()
endif()

add_cppinterop_unittest(CppInterOpTests
EnumReflectionTest.cpp
FunctionReflectionTest.cpp
InterpreterTest.cpp
FunctionReflectionTest.cpp
EnumReflectionTest.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to order this alphabetically.

JitTest.cpp
ScopeReflectionTest.cpp
TypeReflectionTest.cpp
Expand Down
4 changes: 1 addition & 3 deletions unittests/CppInterOp/InterpreterTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ TEST(InterpreterTest, DebugFlag) {
}

TEST(InterpreterTest, Evaluate) {
#ifdef EMSCRIPTEN
GTEST_SKIP() << "Test fails for Emscipten builds";
#endif
#ifdef _WIN32
GTEST_SKIP() << "Disabled on Windows. Needs fixing.";
#endif
Expand All @@ -71,6 +68,7 @@ TEST(InterpreterTest, Evaluate) {
//EXPECT_TRUE(Cpp::Evaluate(I, "__cplusplus;") == 201402);
// Due to a deficiency in the clang-repl implementation to get the value we
// always must omit the ;
Cpp::CreateInterpreter();
EXPECT_TRUE(Cpp::Evaluate("__cplusplus") == 201402);

bool HadError;
Expand Down
Loading