Skip to content

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Apr 2, 2025

Description

Please include a summary of changes, motivation and context for this PR.

Now that the Emscripten build of xeus-cpp builds tests, we can now run them as part of the Emscripten workflow in CppInterOp. This allows us to ensure that any changes to Emscripten build/functionality of CppInterOp doesn't break the Emscripten build/functionality of xeus-cpp.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton changed the title Run xeus-cpp-lite tests Run xeus-cpp-lite tests Emscripten workflows Apr 2, 2025
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (3258584) to head (8ab7d4c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files           9        9           
  Lines        3646     3646           
=======================================
  Hits         2769     2769           
  Misses        877      877           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good !

@anutosh491 anutosh491 merged commit 27847e4 into compiler-research:main Apr 3, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants