Skip to content

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 28, 2025

Description

Please include a summary of changes, motivation and context for this PR.

This PR remove LLVM_ENABLE_ZSTD=OFF ,LLVM_ENABLE_TERMINFO=OFF and LLVM_ENABLE_LIBXML2=OFF options llvm native build. These options were added when CppInterOp was trying to combine the Emscripten and native llvm builds into 1.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton changed the title Remove LLVM_ENABLE_ZSTD=OFF, ,LLVM_ENABLE_TERMINFO=OFF and LLVM_ENABL… Remove LLVM_ENABLE_ZSTD=OFF, ,LLVM_ENABLE_TERMINFO=OFF and LLVM_ENABLE_LIBXML2=OFF options llvm native build May 28, 2025
@mcbarton mcbarton changed the title Remove LLVM_ENABLE_ZSTD=OFF, ,LLVM_ENABLE_TERMINFO=OFF and LLVM_ENABLE_LIBXML2=OFF options llvm native build Remove LLVM_ENABLE_ZSTD=OFF, LLVM_ENABLE_TERMINFO=OFF and LLVM_ENABLE_LIBXML2=OFF options llvm native build May 28, 2025
@mcbarton mcbarton requested a review from vgvassilev May 28, 2025 17:12
@mcbarton
Copy link
Collaborator Author

This PR is ready for review.

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (29f2920) to head (7c32ecb).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files           9        9           
  Lines        3691     3691           
=======================================
  Hits         2855     2855           
  Misses        836      836           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 3727acc into compiler-research:main May 29, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants