Skip to content

Conversation

@mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented May 28, 2025

Description

Please include a summary of changes, motivation and context for this PR.

This PR fixes some long standing bugs in documentation relating to environment variables.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton requested a review from vgvassilev May 28, 2025 17:41
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (dd50000) to head (a7a876d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   77.66%   77.66%           
=======================================
  Files           9        9           
  Lines        3743     3743           
=======================================
  Hits         2907     2907           
  Misses        836      836           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton
Copy link
Collaborator Author

This PR is ready for review

@mcbarton mcbarton requested a review from aaronj0 May 29, 2025 09:44
@mcbarton mcbarton changed the title Fix bugs in documentation relating to cling based build Fix bugs in documentation relating to environment variables May 29, 2025
@mcbarton mcbarton requested a review from aaronj0 May 29, 2025 12:49
@mcbarton mcbarton force-pushed the Fix-bugs-in-documentation branch from 571f78d to cf1b668 Compare June 2, 2025 08:23
@mcbarton mcbarton requested a review from Vipul-Cariappa June 5, 2025 19:07
Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcbarton mcbarton dismissed aaronj0’s stale review June 6, 2025 07:02

Already done this change in another PR which has already been merged in

@mcbarton mcbarton merged commit e05026a into compiler-research:main Jun 6, 2025
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants