fix: codegen need not instantiate func body if it can be resolved #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
+ Coverage 77.77% 77.96% +0.19%
==========================================
Files 9 9
Lines 3761 3767 +6
==========================================
+ Hits 2925 2937 +12
+ Misses 836 830 -6
🚀 New features to boost your workflow:
|
Contributor
|
It would be good to cover that with tests. |
Vipul-Cariappa
force-pushed
the
dev/codegen-host-templ
branch
from
5570307 to
e19a731
Compare
Vipul-Cariappa
force-pushed
the
dev/codegen-host-templ
branch
2 times, most recently
from
703de04 to
b20d0d7
Compare
vgvassilev
reviewed
Jun 13, 2025
| EXPECT_EQ(instantiation_in_host_callable.getKind(), | ||
| Cpp::JitCall::kUnknown); // expect to fail with | ||
| // TClingCallFunc::make_wrapper: | ||
| // instantiation with no body! |
Contributor
There was a problem hiding this comment.
Why not capturing the error?
This is the case where the the instantiated function is present in one of the libraries loaded or the host application.
Vipul-Cariappa
force-pushed
the
dev/codegen-host-templ
branch
from
b20d0d7 to
7a1ca48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the case where the instantiated function is present in one of the libraries loaded or the host application.
Fixes # (issue)
Fixes a test in cppyy.
Type of change
Please tick all options which are relevant.
Testing
Tests included.
Checklist