remote jit execution #631
remote jit execution #631
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| #include "llvm/Support/Error.h" | ||
|
|
||
| #include "clang/Interpreter/RemoteJITUtils.h" |
There was a problem hiding this comment.
warning: 'clang/Interpreter/RemoteJITUtils.h' file not found [clang-diagnostic-error]
#include "clang/Interpreter/RemoteJITUtils.h"
^| #include "llvm/Support/Error.h" | ||
|
|
||
| #include "clang/Interpreter/RemoteJITUtils.h" | ||
| #include "clang/Basic/Version.h" |
There was a problem hiding this comment.
warning: #includes are not sorted properly [llvm-include-order]
| #include "clang/Basic/Version.h" | |
| #include "clang/Basic/Version.h" | |
| #include "clang/Interpreter/RemoteJITUtils.h" |
| #include "llvm/ExecutionEngine/Orc/Debugging/DebuggerSupport.h" | ||
|
|
||
| #include "llvm/Support/CommandLine.h" | ||
|
|
There was a problem hiding this comment.
warning: included header CommandLine.h is not used directly [misc-include-cleaner]
|
|
||
| #include "llvm/Support/CommandLine.h" | ||
|
|
||
| static llvm::ExitOnError ExitOnError; |
There was a problem hiding this comment.
warning: variable 'ExitOnError' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
static llvm::ExitOnError ExitOnError;
^| std::unique_ptr<llvm::orc::LLJITBuilder> JB; | ||
|
|
||
| if(is_out_of_process) { | ||
| std::string OOPExecutor = "/Users/abhinavkumar/Desktop/Coding/CERN_HSF_COMPILER_RESEARCH/llvm-project-test/build/bin/llvm-jitlink-executor"; |
There was a problem hiding this comment.
warning: no header providing "std::string" is directly included [misc-include-cleaner]
lib/CppInterOp/Compatibility.h:10:
+ #include <string>|
|
||
| TInterp_t CreateInterpreter(const std::vector<const char*>& Args /*={}*/, | ||
| const std::vector<const char*>& GpuArgs /*={}*/) { | ||
| const std::vector<const char*>& GpuArgs /*={}*/, bool is_out_of_process) { |
There was a problem hiding this comment.
warning: 'MakeResourcesPath' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
| const std::vector<const char*>& GpuArgs /*={}*/, bool is_out_of_process) { | |
| std::string MakeResourcesPath() { |
1 participant
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist