fix: codegen for templates with multiple parameter packs #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapted from cling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
+ Coverage 78.69% 78.77% +0.07%
==========================================
Files 9 9
Lines 3835 3849 +14
==========================================
+ Hits 3018 3032 +14
Misses 817 817
🚀 New features to boost your workflow:
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Jun 20, 2025
| SourceLocation noLoc; | ||
| QualType TT = S.CheckTemplateIdType(TemplateName(TemplateD), noLoc, TLI); | ||
| if (TT.isNull()) | ||
| return nullptr; |
Contributor
There was a problem hiding this comment.
I'd drop that if we can't cover it with tests.
Collaborator
Author
There was a problem hiding this comment.
This is required; it is due to a template instantiation failing in Eigen (crashes).
Also, fixing the instantiation in this PR does not make sense. Will look into that once I get to the eigen tests.
And writing a test that is supposed to fail is bad again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adapted from cling
Fixes # (issue)
Fixes 2 issues in cppyy.
Type of change
Please tick all options which are relevant.
Testing
Included.
Checklist