Skip to content

Conversation

@Vipul-Cariappa
Copy link
Collaborator

Description

Look at the test.

Fixes # (issue)

Helps fix 1 test in cppyy.

Type of change

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Included.

Checklist

  • I have read the contribution guide recently

@Vipul-Cariappa Vipul-Cariappa marked this pull request as draft June 26, 2025 12:17
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.78%. Comparing base (3bc692b) to head (af0f82c).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   78.77%   78.78%   +0.01%     
==========================================
  Files           9        9              
  Lines        3849     3851       +2     
==========================================
+ Hits         3032     3034       +2     
  Misses        817      817              
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOp.cpp 86.68% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOp.cpp 86.68% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vipul-Cariappa Vipul-Cariappa marked this pull request as ready for review June 26, 2025 12:29
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Vipul-Cariappa Vipul-Cariappa merged commit 180869d into compiler-research:main Jun 26, 2025
50 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the dev/class-lazy-definition branch June 26, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants