Stop unused variable warnings if llvm built with assertions off #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This PR is ready for review. The motivation for wanting to be able to build CppInterOp with llvm assertions off is described in the PR description. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Fix-unused-variable-warning-if-llvm-enable-assertions-off
branch
from
2ad2f93 to
8f5f3b8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 9 9
Lines 3917 3917
=======================================
Hits 3115 3115
Misses 802 802
🚀 New features to boost your workflow:
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
The motivation for this PR is to offer a route to a smaller Emscripten shared library. If you build llvm without assertions at the moment you will get unused variable warnings in CppInterOp. This PR fixes these warnings. The reason for wanting CppInterOp to be able to be built without assertions, is that if you turn them off it has a noticeable effect on the size of the Emscripten shared library. The Oz and flto flags bring the size down to 44Mb. If you turn off assertions, then the size reduces further to 39Mb.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist