Skip to content

Remove restriction on number of processes for Emscripten static library build on MacOS Github runners #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

Remove restriction on number of processes for Emscripten static library build on MacOS Github runners #713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8873dd2
Remove restriction on number of processes for Emscripten static libra…
mcbarton Sep 16, 2025
199a4e3
Update emscripten.yml
mcbarton Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/emscripten.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ jobs:
if [[ "${os}" != macos* ]] ; then
EMCC_CORES=1 emmake make -j 1 check-cppinterop
else
EMCC_CORES=2 emmake make -j 2 check-cppinterop
emmake make -j ${{ env.ncpus }} check-cppinterop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not doing the same for other OS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the Linux jobs still crash the ci if you remove the restriction for them. This PR allows us at least remove the restriction on the MacOS jobs while we are able to. Once this is in I plan to open another PR which removes the restriction on the Linux jobs, and I will just keep rebasing that PR every time a new PR goes in until it passes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, is it a problem with emscripten?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you can do these build with enough resources (e.g. locally on your laptop which will have more memory). There is no problem with Emscripten. The Github runners are too limited in resources to allow you to do these builds with multiple jobs (at least for now with Linux).

fi
cd ./unittests/CppInterOp/
# Explaination of options for emrun
Expand Down
Loading