Skip to content

Conversation

@Vipul-Cariappa
Copy link
Collaborator

Description

Overload resolution for template pack of rvalue reference

Fixes # (issue)

Enables things at cppyy.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Included

Checklist

  • I have read the contribution guide recently

Copy link
Collaborator

@aaronj0 aaronj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

(assuming tests pass)

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.04%. Comparing base (2df83a9) to head (a5b4c5e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files           9        9           
  Lines        3879     3879           
=======================================
  Hits         3066     3066           
  Misses        813      813           
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOp.cpp 87.60% <100.00%> (ø)
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOp.cpp 87.60% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vipul-Cariappa Vipul-Cariappa merged commit 935ff11 into compiler-research:main Nov 26, 2025
36 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the dev/rvalue-ref-BestOverloadFunctionMatch branch November 26, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants