change all enum to enum class
#759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| constexpr explicit operator bool() const { return underlying(t); } | ||
| }; | ||
|
|
||
| template <typename T> using Underlying = std::underlying_type_t<T>; |
Contributor
There was a problem hiding this comment.
warning: no header providing "std::underlying_type_t" is directly included [misc-include-cleaner]
include/CppInterOp/CppInterOp.h:22:
- #include <vector>
+ #include <type_traits>
+ #include <vector>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 79.04% 79.08% +0.04%
==========================================
Files 9 9
Lines 3879 3888 +9
==========================================
+ Hits 3066 3075 +9
Misses 813 813
🚀 New features to boost your workflow:
|
vgvassilev
reviewed
Nov 27, 2025
|
|
||
| constexpr TruthValue<OperatorArity> operator&(OperatorArity l, | ||
| OperatorArity r) { | ||
| return OperatorArity(underlying(l) & underlying(r)); |
Contributor
There was a problem hiding this comment.
I do not think arity could be xor-ed -- we have already kBoth.
| using TCppObject_t = void*; | ||
|
|
||
| enum Operator : unsigned char { | ||
| template <typename T> struct TruthValue { |
Contributor
There was a problem hiding this comment.
I suspect we can forward declare the operators and implement them in the cpp file and then we could hide this class completely from the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.