Move runtime template code to CPPInterOpRuntime.h for issue #697 #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include "CppInterOp/CppInterOp.h" | ||
|
|
||
| #include "CppInterOpRuntime.h" | ||
|
|
Contributor
There was a problem hiding this comment.
warning: included header CppInterOpRuntime.h is not used directly [misc-include-cleaner]
Suggested change
| @@ -0,0 +1,19 @@ | |||
| #ifndef CPPINTEROP_RUNTIME_H | |||
| #define CPPINTEROP_RUNTIME_H | |||
Contributor
There was a problem hiding this comment.
warning: header guard does not follow preferred style [llvm-header-guard]
Suggested change
| #define CPPINTEROP_RUNTIME_H | |
| #ifndef GITHUB_WORKSPACE_LIB_CPPINTEROP_CPPINTEROPRUNTIME_H | |
| #define GITHUB_WORKSPACE_LIB_CPPINTEROP_CPPINTEROPRUNTIME_H |
lib/CppInterOp/CppInterOpRuntime.h:18:
- #endif // CPPINTEROP_RUNTIME_H
+ #endif // GITHUB_WORKSPACE_LIB_CPPINTEROP_CPPINTEROPRUNTIME_H| // interpreter using I->declare(). It is now provided as a real header so that | ||
| // the interpreter can load it on startup. | ||
|
|
||
| namespace __internal_CppInterOp { |
Contributor
There was a problem hiding this comment.
warning: declaration uses identifier '__internal_CppInterOp', which is a reserved identifier [bugprone-reserved-identifier]
Suggested change
| namespace __internal_CppInterOp { | |
| namespace internal_CppInterOp { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Moved the runtime-only
__internal_CppInterOp::functiontemplate from the interpreter-injected string inCppInterOp.cppinto its own header fileCppInterOpRuntime.h.This makes the code cleaner, easier to maintain, and aligns with the reviewer suggestion from https://github.com/compiler-research/CppInterOp/pull/678/files#r2242837167 .
Changes
lib/CppInterOp/CppInterOpRuntime.hwith the template definition.I->declare(...)runtime template block fromCppInterOp.cpp.CppInterOp.cpp.Motivation
Previously, the template code was injected into the interpreter at startup using a string. Moving it to a proper header:
Fixes issue #697
Type of change
Please tick all options which are relevant.
Checklist