Skip to content

Drop smallpt notebook reference from Emscripten build instructions #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
Merged

Drop smallpt notebook reference from Emscripten build instructions #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/deploy-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ jobs:
micromamba activate xeus-lite-host
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }} \
--contents notebooks/xeus-cpp-lite-demo.ipynb \
--contents notebooks/smallpt.ipynb \
--contents notebooks/images/marie.png \
--contents notebooks/audio/audio.wav \
--XeusAddon.mounts="${{ env.PREFIX }}/share/xeus-cpp/tagfiles:/share/xeus-cpp/tagfiles" \
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/emscripten.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,7 +1037,7 @@ jobs:
cd ./xeus-cpp/
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyterlite-xeus jupyter_server jupyterlab notebook python-libarchive-c -c conda-forge
micromamba activate xeus-lite-host
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }} --contents notebooks/xeus-cpp-lite-demo.ipynb --contents notebooks/smallpt.ipynb --contents notebooks/images/marie.png --contents notebooks/audio/audio.wav --output-dir dist
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }} --contents notebooks/xeus-cpp-lite-demo.ipynb --contents notebooks/images/marie.png --contents notebooks/audio/audio.wav --output-dir dist

- name: Jupyter Lite integration
if: ${{ runner.os == 'windows' }}
Expand All @@ -1046,4 +1046,4 @@ jobs:
cd .\xeus-cpp\
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyterlite-xeus jupyter_server jupyterlab notebook python-libarchive-c -c conda-forge
micromamba activate xeus-lite-host
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }} --contents notebooks/xeus-cpp-lite-demo.ipynb --contents notebooks/smallpt.ipynb --contents notebooks/images/marie.png --contents notebooks/audio/audio.wav --output-dir dist
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }} --contents notebooks/xeus-cpp-lite-demo.ipynb --contents notebooks/images/marie.png --contents notebooks/audio/audio.wav --output-dir dist
2 changes: 0 additions & 2 deletions Emscripten-build-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyterlite-xeus jupyte
micromamba activate xeus-lite-host
jupyter lite serve --XeusAddon.prefix=$PREFIX \
--contents xeus-cpp/notebooks/xeus-cpp-lite-demo.ipynb \
--contents xeus-cpp/notebooks/smallpt.ipynb \
--contents xeus-cpp/notebooks/images/marie.png \
--contents xeus-cpp/notebooks/audio/audio.wav \
--XeusAddon.mounts="$PREFIX/share/xeus-cpp/tagfiles:/share/xeus-cpp/tagfiles" \
Expand All @@ -403,7 +402,6 @@ micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyterlite-xeus jupyte
micromamba activate xeus-lite-host
jupyter lite serve --XeusAddon.prefix="$env:PREFIX" `
--contents xeus-cpp/notebooks/xeus-cpp-lite-demo.ipynb `
--contents xeus-cpp/notebooks/smallpt.ipynb `
--contents xeus-cpp/notebooks/images/marie.png `
--contents xeus-cpp/notebooks/audio/audio.wav `
--XeusAddon.mounts="$env:PREFIX/share/xeus-cpp/tagfiles:/share/xeus-cpp/tagfiles" `
Expand Down
4 changes: 1 addition & 3 deletions docs/Emscripten-build-instructions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ To build and test Jupyter Lite with this kernel locally on Linux/MacOS you can e
micromamba activate xeus-lite-host
jupyter lite serve --XeusAddon.prefix=$PREFIX \
--contents xeus-cpp/notebooks/xeus-cpp-lite-demo.ipynb \
--contents xeus-cpp/notebooks/smallpt.ipynb \
--contents xeus-cpp/notebooks/images/marie.png \
--contents xeus-cpp/notebooks/audio/audio.wav \
--XeusAddon.mounts="$PREFIX/share/xeus-cpp/tagfiles:/share/xeus-cpp/tagfiles" \
Expand All @@ -425,8 +424,7 @@ and on Windows execute
micromamba activate xeus-lite-host
jupyter lite serve --XeusAddon.prefix="$env:PREFIX" `
--contents xeus-cpp/notebooks/xeus-cpp-lite-demo.ipynb `
--contents xeus-cpp/notebooks/smallpt.ipynb `
--contents xeus-cpp/notebooks/images/marie.png `
--contents xeus-cpp/notebooks/audio/audio.wav `
--XeusAddon.mounts="$env:PREFIX/share/xeus-cpp/tagfiles:/share/xeus-cpp/tagfiles" `
--XeusAddon.mounts="$env:PREFIX/etc/xeus-cpp/tags.d:/etc/xeus-cpp/tags.d"
--XeusAddon.mounts="$env:PREFIX/etc/xeus-cpp/tags.d:/etc/xeus-cpp/tags.d"
Loading