Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 11 11
Lines 4013 4013
=======================================
Hits 3193 3193
Misses 820 820
🚀 New features to boost your workflow:
|
| TKCASE(ExtVector); | ||
| TKCASE(MemberPointer); | ||
| TKCASE(Auto); | ||
| #if CLANG_VERSION_MAJOR < 22 |
There was a problem hiding this comment.
warning: no header providing "CLANG_VERSION_MAJOR" is directly included [misc-include-cleaner]
lib/CppInterOp/CXCppInterOp.cpp:16:
- #include <cstring>
+ #include <clang/Basic/Version.h>
+ #include <cstring>|
Failing tests Emscripten build Following test crashes googletest for native build Given this test fails for Emscripten case, it feels likely that all tests which fail for the Emscripten case also fail for the native case. |
|
@aaronj0 I tried your suggestion here #836 (comment) locally for getExecutionEngine, and llvm 22 still fails in the same way this PR does with janks solution (for example getting fyi I haven't had time yet to determine if the |
#773 was previously trying to do too much at once, so this PR limits itself to just changes relating to updating CppInterOp to be compatible with llvm 22. This PR will also not update the oop jobs which will be left to someone else to do.