Skip to content

Fix FIXME: thread-safe initialization of DispatchInitializer #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
voyager-jhk wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix FIXME: thread-safe initialization of DispatchInitializer #844

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfe78df
Make DispatchInitializer thread-safe using function-local static
voyager-jhk Mar 9, 2026
175a0b2
Address clang-tidy warnings
voyager-jhk Mar 10, 2026
a57c455
Move DispatchInitializer to function static for thread safety
voyager-jhk Mar 11, 2026
4ce13f7
Fix global initialization to satisfy clang-tidy
voyager-jhk Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions unittests/CppInterOp/Utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ struct DispatchInitializer {
DispatchInitializer(DispatchInitializer&&) noexcept = default;
DispatchInitializer& operator=(DispatchInitializer&&) noexcept = default;
};
// FIXME: Make this threadsafe by moving it as a function static.
DispatchInitializer g_dispatch_init;
// Thread-safe initialization using function-local static
DispatchInitializer& GetDispatchInitializer() {
static DispatchInitializer instance;
return instance;
}
DispatchInitializer& g_dispatch_init = GetDispatchInitializer();
Copy link
Contributor

@github-actions github-actions bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'g_dispatch_init' provides global access to a non-const object; consider making the referenced data 'const' [cppcoreguidelines-avoid-non-const-global-variables]

DispatchInitializer& g_dispatch_init = GetDispatchInitializer();
                     ^

} // namespace
#endif

Expand Down
Loading