docs: remove specific nproc/sysctl thread counts from cmake parallel build instructions#860
Open
aniruddhaadak80 wants to merge 1 commit intocompiler-research:mainfrom
Open
Conversation
…build instructions (fixes compiler-research#395)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #395
Description
This PR cleans up the build instructions across the
README.mdto simplifycmake --buildexecution. Using system specific process count utilities like$(nproc --all),$(sysctl -n hw.ncpu), or$env:ncpushas been prone to failure on missing packages or misconfigured shells.Changes Made
--parallelinside theREADME.md.--parallelargument across all major build platforms (Ninja, MSBuild, Make).