ramntupleview refactor #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update properly the pr description to capture what this change is really about? |
|
Done @vgvassilev |
|
Can you split the refactoring from the readme update into two PRs? |
AdityaPandeyCN
force-pushed
the
develop
branch
from
4d4fb81 to
cc136cf
Compare
Signed-off-by: AdityaPandeyCN <[email protected]> remove img Signed-off-by: AdityaPandeyCN <[email protected]>
AdityaPandeyCN
force-pushed
the
develop
branch
from
b1133a2 to
4df3203
Compare
|
Hello @vgvassilev reverted the readme changes. |
|
Can you add tests making sure this change is what we want it to be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates refactors the
ramntupleviewtool from a standalone macro to a proper executable that links against the ramcore library, following the same pattern as other tools in the project. This provides better code organization and reusability.