Update to use CppInterOp 1.4.0 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 80.14% 80.14%
=======================================
Files 19 19
Lines 972 972
Branches 93 93
=======================================
Hits 779 779
Misses 193 193 |
|
Though I made the update for cppinterop on emscripten-forge. I am improving the llvm recipe we have (emscripten-forge/recipes#1384) and then I shall rebuild cppinterop to use this llvm. That should be a better, cleaner and more efficient build. |
mcbarton
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that cppinterop 1.4.0 is available on conda-forge and emscripten-forge, this PR tries to update xeus-cpp to use the latest version. The new release (0.6.0) for xeus-cpp should be made using that version hopefully
Type of change
Please tick all options which are relevant.