Disable xsystem for WASM #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

anutosh491 merged 2 commits into compiler-research:main from tharun571:wasm

Apr 19, 2025

Contributor

tharun571 commented Apr 16, 2025

Description

Shell commands do not work in WASM environment. This PR disables it.

Type of change

Please tick all options which are relevant.

Bug fix
New feature
Added/removed dependencies
Required documentation updates

codecov-commenter commented Apr 16, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.15%. Comparing base (160dce0) to head (c85c281).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   82.15%   82.15%           
=======================================
  Files          20       20           
  Lines         958      958           
  Branches       88       88           
=======================================
  Hits          787      787           
  Misses        171      171

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Contributor

github-actions bot commented Apr 16, 2025

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment

Contributor

github-actions bot commented Apr 16, 2025

clang-tidy review says "All clean, LGTM! 👍"

anutosh491 reviewed

View reviewed changes

test/test_interpreter.cpp Outdated Show resolved Hide resolved

tharun571 force-pushed the wasm branch 3 times, most recently from 5416e4c to 9fd5a85 Compare

April 17, 2025 13:04

Contributor

github-actions bot commented Apr 17, 2025

clang-tidy review says "All clean, LGTM! 👍"


          Disable Xsystem for WASM

0c1e9c4

tharun571 force-pushed the wasm branch from 9fd5a85 to 0c1e9c4 Compare

April 17, 2025 13:17

Contributor

github-actions bot commented Apr 17, 2025

clang-tidy review says "All clean, LGTM! 👍"

anutosh491 reviewed

View reviewed changes

src/xsystem.hpp Outdated Show resolved Hide resolved


          Update XSystem

c85c281

Contributor

github-actions bot commented Apr 19, 2025

clang-tidy review says "All clean, LGTM! 👍"

anutosh491 approved these changes

View reviewed changes

Collaborator

anutosh491 left a comment

Looks good.
This is not expected to work for the wasm build (so its not that it fails, it just isn't expected to work .... Can we make that a bit more clear in the PR description ?) !!!

anutosh491 merged commit baf3bb7 into compiler-research:main

16 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet