Skip to content

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jun 6, 2025

Description

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

While trying something out earlier I noticed xeus-cpp picked up the creation of a .DS_Store . On projects I work on this file is usually added to the .gitignore, so it isn't accidentally picked up . This PR does this.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (7ecb686) to head (adeef85).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anutosh491
Copy link
Collaborator

Hmm what were you trying out ?

I am on macos and I've never encountered the creation of a DS_Store

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jun 6, 2025

@anutosh491 What I was trying out was irrelavent. Its not why it was created. It was created because I opened up my xeus-cpp folder using finder, or edited one the files in the folder starting from finder. I don't know which. See https://en.m.wikipedia.org/wiki/.DS_Store for more details on the file.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jun 6, 2025

Here is an example of where is has been added in another repo https://github.com/actions/runner-images/blob/ecb9d4051afe957263ec15fcb1db71472abd9ad8/.gitignore#L300 . Its quite a common file to show up when developing on macos. I'm quite surprised you've never come accross it to be honest.

@anutosh491
Copy link
Collaborator

I'm quite surprised you've never come accross it to be honest.

I mean I've heard of it but never come across anything involving it in a "xeus-cpp" context.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@SylvainCorlay SylvainCorlay merged commit 3a888b6 into compiler-research:main Jun 7, 2025
25 of 27 checks passed
@mcbarton mcbarton deleted the add-.DS_Store-to-.gitignore branch June 27, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants