Skip to content

Remove redundant wasm interpreter class #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

Remove redundant wasm interpreter class #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,6 @@ if(NOT EMSCRIPTEN)
)
endif()

if(EMSCRIPTEN)
list(APPEND XEUS_CPP_SRC src/xinterpreter_wasm.cpp)
endif()

set(XEUS_CPP_MAIN_SRC
src/main.cpp
)
Expand Down
28 changes: 0 additions & 28 deletions include/xeus-cpp/xinterpreter_wasm.hpp
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/main_emscripten_kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

#include <xeus/xembind.hpp>

#include "xeus-cpp/xinterpreter_wasm.hpp"
#include "xeus-cpp/xinterpreter.hpp"

template <class interpreter_type>
static interpreter_type* builder_with_args(emscripten::val js_args)
Expand All @@ -39,6 +39,6 @@ static interpreter_type* builder_with_args(emscripten::val js_args)
EMSCRIPTEN_BINDINGS(my_module)
{
xeus::export_core();
using interpreter_type = xcpp::wasm_interpreter;
using interpreter_type = xcpp::interpreter;
xeus::export_kernel<interpreter_type, &builder_with_args<interpreter_type>>("xkernel");
}
22 changes: 0 additions & 22 deletions src/xinterpreter_wasm.cpp
View file
Open in desktop

This file was deleted.

Loading