Skip to content

Conversation

@mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

We don't support c++11 or c++14 kernels anymore, so these lines are unneeded

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@anutosh491
Copy link
Collaborator

anutosh491 commented Oct 23, 2025

Well the user can still configure their kernels to use those versions right ?

I guess we should still keep them !

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.77%. Comparing base (c7628c6) to head (dbd4d9e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   81.78%   81.77%   -0.02%     
==========================================
  Files          20       20              
  Lines         950      845     -105     
  Branches       87       87              
==========================================
- Hits          777      691      -86     
+ Misses        173      154      -19     
Files with missing lines Coverage Δ
src/xinterpreter.cpp 90.56% <ø> (+0.45%) ⬆️

... and 13 files with indirect coverage changes

Files with missing lines Coverage Δ
src/xinterpreter.cpp 90.56% <ø> (+0.45%) ⬆️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton
Copy link
Collaborator Author

Well the user can still configure their kernels to use those versions right ?

I guess we should still keep them !

Closing as per this comment

@mcbarton mcbarton closed this Oct 23, 2025
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants