Skip to content

Use latest node version to run wasm based tests #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use latest node version to run wasm based tests #400

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a137c7
Use latest node version to run wasm based tests
anutosh491 Oct 24, 2025
0c1905f
add jupyter_server
anutosh491 Oct 24, 2025
fa6d431
add exit runtime to exit after main is done
anutosh491 Oct 24, 2025
1dc510c
Try node version 24
anutosh491 Oct 24, 2025
e49e7e4
node version
anutosh491 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/deploy-github-page.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,15 @@ jobs:
..
emmake make -j ${{ env.ncpus }} install

- name: Setup latest Node.js
uses: actions/setup-node@v4
with:
node-version: 'latest'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user needs to use the latest node for the Emscripten tests to pass in the referenced PR, then this would needs to be mentioned in the readme. The user may not have the latest node installed, and executing node will get emsdks downloaded version. We should be using the node version which comes with emsdk to be consistent. When we move to a newer emsdk we get a very recent node. Maybe for now we need something in the readme about emsdk install node-24.7.0-64bit


- name: Test xeus-cpp C++ Emscripten
shell: bash -l {0}
run: |
set -e
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus
micromamba activate xeus-lite-host
cd build/test
# Fresh install browsers, and run Emscripten tests in them
# This is to match the Emscripten build instructions, where
Expand Down Expand Up @@ -140,6 +143,7 @@ jobs:
- name: Jupyter Lite integration
shell: bash -l {0}
run: |
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus -c conda-forge
micromamba activate xeus-lite-host
jupyter lite build \
--XeusAddon.prefix=${{ env.PREFIX }} \
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,13 +249,16 @@ jobs:
..
emmake make -j ${{ env.ncpus }} install

- name: Setup latest Node.js
uses: actions/setup-node@v4
with:
node-version: 'latest'

- name: Test xeus-cpp C++ Emscripten
shell: bash -l {0}
run: |
export BUILD_PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-cpp-wasm-build
set -e
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyterlite-xeus
micromamba activate xeus-lite-host
cd build/test
# Fresh install browsers, and run Emscripten tests in them
# This is to match the Emscripten build instructions, where
Expand Down Expand Up @@ -329,6 +332,7 @@ jobs:
- name: Jupyter Lite integration
shell: bash -l {0}
run: |
micromamba create -n xeus-lite-host jupyterlite-core=0.6 jupyter_server jupyterlite-xeus -c conda-forge
micromamba activate xeus-lite-host
jupyter lite build --XeusAddon.prefix=${{ env.PREFIX }}

Expand Down
1 change: 1 addition & 0 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ if(EMSCRIPTEN)
PUBLIC "SHELL: -s WASM_BIGINT"
PUBLIC "SHELL: -s ASSERTIONS=0"
PUBLIC "SHELL: -s ALLOW_MEMORY_GROWTH=1"
PUBLIC "SHELL: -s EXIT_RUNTIME=1"
PUBLIC "SHELL: -s STACK_SIZE=32mb"
PUBLIC "SHELL: -s INITIAL_MEMORY=128mb"
PUBLIC "SHELL: --preload-file ${ESCAPED_SYSROOT_PATH}/include@/include"
Expand Down
Loading