Skip to content

Conversation

@Olen
Copy link
Contributor

@Olen Olen commented Oct 31, 2024

List allowed types in verbose error output.

Since commit types are configureable it might be useful to list them in the verbose error messages

Olen and others added 2 commits October 31, 2024 18:38
List allowed types in verbose error output
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you that this would be nice to include in the output.

I think it should be done a little differently though, to align with how scope is handled:

  • Append the line only when group == "type"
  • Create the joined list of options (types) before using it in the appended line
  • Follow the format and color scheme of other lines, specifically using the list of scopes line as an example to follow

Hopefully this makes sense, let me know if you have any questions.

@thekaveman
Copy link
Member

Thanks for your work on this @Olen.

I've cherry-picked your commit into a larger refactor PR I'm working on in #119, so rest assure this change will be merged with that PR.

@thekaveman thekaveman closed this Nov 22, 2024
@Olen
Copy link
Contributor Author

Olen commented Nov 22, 2024

Happy to hear that.
Sorry I was unable to follow up before. Way to many projects right now.

@thekaveman
Copy link
Member

I hear you! Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants