feat(driver): buffer pool#358
Merged
Berrysoft merged 13 commits intocompio-rs:masterfrom Mar 15, 2025
Merged
Conversation
This was referenced Dec 19, 2024
Closed
f174bff to
c5f9dec
Compare
Member
Author
|
@George-Miao If you have time, review this PR first, please. It will be the most important feature of compio in the next release. |
George-Miao
previously approved these changes
Mar 12, 2025
George-Miao
reviewed
Mar 13, 2025
George-Miao
reviewed
Mar 13, 2025
George-Miao
reviewed
Mar 13, 2025
Co-authored-by: Pop <gm@miao.dev>
George-Miao
approved these changes
Mar 15, 2025
George-Miao
added a commit
to George-Miao/compio
that referenced
this pull request
May 27, 2025
* feat(driver,iocp): buffer pool * feat(driver): buffer ring * ci: test buf-ring * fix(driver,fusion): check buf-ring * fix(iocp): remove unused imports * fix(driver): return buffer back if op cancelled * fix(driver): use OwnedBuffer * fix(driver): drop pool and forget owned buffer * fix: warnings from clippy * doc: add more comments * fix(iour): comments on reuse_buffer * Apply suggestions from code review Co-authored-by: Pop <gm@miao.dev> * fix(iour): make get_buffer return Result --------- Co-authored-by: Pop <gm@miao.dev> Co-authored-by: Sherlock Holo <sherlockya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is splited from #276 , with some changes.
/cc: @Sherlock-Holo
Don't forget to add
Co-authored-bywhen merging.