Skip to content

attempt to resolve timeout issues#390

Closed
jthrilly wants to merge 3 commits intoe2e-testingfrom
e2e-experiment
Closed

attempt to resolve timeout issues#390
jthrilly wants to merge 3 commits intoe2e-testingfrom
e2e-experiment

Conversation

@jthrilly
Copy link
Member

@jthrilly jthrilly commented May 23, 2025

This pull request refactors and enhances end-to-end tests for the Participants page and the Complete E2E Test Protocol interview. Key improvements include better synchronization using Playwright's waiting mechanisms, improved test reliability, and enhanced readability through comments and structured actions.

Enhancements to Participants page tests:

  • Improved page synchronization by replacing waitForTimeout with Playwright's waitForLoadState and auto-waiting assertions to ensure elements are fully loaded before interacting.
  • Added explicit waits for modals, dropdowns, and other UI elements to appear or update before proceeding with actions, improving test stability. [1] [2]

Improvements to Complete E2E Test Protocol interview tests:

  • Added explicit waits for UI elements (e.g., forms, prompts, and drag-and-drop targets) to ensure they are ready before interactions, reducing flakiness. [1] [2]
  • Enhanced drag-and-drop interactions by waiting for target areas and verifying node placement after each action. [1] [2]
  • Introduced Redux state validation (e.g., waitForNodeCount and waitForEdgeCount) to confirm application state updates after interactions. [1] [2]
  • Replaced hard-coded delays with Playwright's waiting mechanisms for transitions between prompts and edge creation, improving test efficiency and reliability. [1] [2]

These changes significantly improve the reliability, maintainability, and clarity of the test suite.

@vercel
Copy link

vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fresco-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2025 10:15am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
barf ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 10:15am

@github-actions
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report to review the visual differences.
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots
Example: /approve-snapshots https://fresco-sandbox.vercel.app/

@jthrilly jthrilly closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant