Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ering as label; add negative margin back to scroll area
- Update ActivityFeed and SummaryStatistics to accept promises as props - Add dashboard loading.tsx for improved loading states - Improve data table components and stories - Update SettingsCard and Heading components - Update visual snapshots for e2e tests
- Update DataTable header to stack on small screens with flex-col/tablet:flex-row - Make search input expand/shrink with tablet:flex-1 and tablet:min-w-0 - Add responsive width classes to participant and interview buttons - Update ImportExportSection control area to be full width on mobile
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
- Skip GitHub API call in CI for VersionSection to ensure consistent visual snapshots (server-side fetch can't be mocked by Playwright) - Use networkidle instead of load for navigation in db-fixture to ensure React hydration completes before tests interact with page - Move page navigation before releasing exclusive lock in cleanup to prevent race condition with other workers attempting TRUNCATE
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
Ensure activity table ordering is deterministic by using explicit, sequential IDs for events (event-001, event-002, event-003). When the ActivityFeed query sorts by "timestamp DESC, id DESC", the IDs now reinforce the timestamp ordering as a secondary sort key. This prevents visual snapshot flakiness if timestamps were ever equal or if there's any edge case in the database ordering.
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
The baseline snapshot had incorrect activity table ordering. The events should display in timestamp DESC order (newest first): 1. Participant Added 2. User Login 3. Protocol Installed Updated baseline to match the corrected ordering.
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
Incorporates v4 fixes: - Interface styling fixes - Side panel encrypted fixes - Preview protocol import data fix - API key assets in preview mode, geospatial interface - Dyad/tie strength census runtime errors fix - Node styling fixes - Allow external data attributes when adding nodes from panels - Narrative interface fix - Click handler and drag working together
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
🎭 Playwright E2E Test Report❌ Tests failed. View the full report here: |
# Conflicts: # .github/workflows/e2e.yml # .storybook/main.ts # actions/appSettings.ts # app/(blobs)/(setup)/_components/OnboardSteps/Documentation.tsx # app/layout.tsx # components/DataTable/ColumnHeader.tsx # components/DynamicLucideIcon.tsx # lib/form/components/fields/Checkbox.js # lib/form/utils/scrollToFirstError.ts # scripts/update-e2e-snapshots.sh # tests/e2e/suites/dashboard/participants.spec.ts # tests/e2e/suites/dashboard/participants.spec.ts-snapshots/participants-empty-state-dashboard-darwin.png # tests/e2e/suites/dashboard/participants.spec.ts-snapshots/participants-empty-state-dashboard-linux.png # tests/e2e/suites/dashboard/participants.spec.ts-snapshots/participants-page-dashboard-darwin.png # tests/e2e/suites/dashboard/participants.spec.ts-snapshots/participants-page-dashboard-linux.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt at a new form system to replace the old, redux-form, based approach.
<Form>component, supporting async onSubmit handler<Field>component, which connects any standard or custom input to the form system. When rendered within<Form />automatically handles registering/unregistering.<FieldSet />component, designed for grouping<Field />components, and conditionally rendering them.useForm,useField, anduseFormValuehooks to enable clean composition patterns, and features such as conditional renderinguseProtocolFormcustom hook, which translates a protocol form definition to a renderable list ofFieldcomponents.