Fix: page overflow by moving netlify badge to specific route groups#639
Merged
Fix: page overflow by moving netlify badge to specific route groups#639
Conversation
moved to dashboard and blobs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
buckhalt
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a page overflow issue by extracting the Netlify badge from the root layout and placing it in specific route group layouts (dashboard and blobs). The badge now only appears on admin-facing pages in sandbox mode, while being removed from interview and other routes.
Changes:
- Created a new
NetlifyBadgecomponent that conditionally renders the badge based on SANDBOX_MODE - Removed the badge and ResponsiveContainer wrapper from the root layout
- Added the badge to the dashboard layout and (blobs) layout
- Fixed overflow in the (blobs) layout by changing container height from
h-[90dvh]tomin-h-dvh
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/NetlifyBadge.tsx | New component that conditionally renders Netlify badge in SANDBOX_MODE |
| app/layout.tsx | Removed Netlify badge and ResponsiveContainer from root layout |
| app/dashboard/layout.tsx | Added NetlifyBadge component to dashboard routes |
| app/(blobs)/layout.tsx | Added NetlifyBadge, fixed container height constraints to prevent overflow, and reordered imports per convention |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved to dashboard and blobs