Skip to content

Fix: Roster interface was not destructuring prompt object, so additio…#659

Merged
jthrilly merged 3 commits intomainfrom
fix/roster-additional-attributes
Mar 9, 2026
Merged

Fix: Roster interface was not destructuring prompt object, so additio…#659
jthrilly merged 3 commits intomainfrom
fix/roster-additional-attributes

Conversation

@jthrilly
Copy link
Member

@jthrilly jthrilly commented Mar 9, 2026

Fix: Roster interface was not destructuring prompt object, so additional attributes selector was failing.

Copilot AI review requested due to automatic review settings March 9, 2026 10:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Name Generator Roster interface so it passes the current prompt object into getAdditionalAttributesSelector, allowing prompt-level additionalAttributes to be applied correctly.

Changes:

  • Add prop-types as an explicit runtime dependency.
  • Update NameGeneratorRoster to destructure prompt from usePrompts().
  • Pass { prompt, ...props } into getAdditionalAttributesSelector via usePropSelector.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Adds prop-types to runtime dependencies to support existing PropTypes usage.
pnpm-lock.yaml Locks prop-types@15.8.1 for consistent installs.
lib/interviewer/containers/Interfaces/NameGeneratorRoster/NameGeneratorRoster.js Ensures the roster interface provides prompt to the additional-attributes selector so prompt attributes are included.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jthrilly jthrilly merged commit 78c137c into main Mar 9, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants