Fix: Roster interface was not destructuring prompt object, so additio…#659
Merged
Fix: Roster interface was not destructuring prompt object, so additio…#659
Conversation
…nal attributes selector was failing
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Name Generator Roster interface so it passes the current prompt object into getAdditionalAttributesSelector, allowing prompt-level additionalAttributes to be applied correctly.
Changes:
- Add
prop-typesas an explicit runtime dependency. - Update
NameGeneratorRosterto destructurepromptfromusePrompts(). - Pass
{ prompt, ...props }intogetAdditionalAttributesSelectorviausePropSelector.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Adds prop-types to runtime dependencies to support existing PropTypes usage. |
pnpm-lock.yaml |
Locks prop-types@15.8.1 for consistent installs. |
lib/interviewer/containers/Interfaces/NameGeneratorRoster/NameGeneratorRoster.js |
Ensures the roster interface provides prompt to the additional-attributes selector so prompt attributes are included. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Roster interface was not destructuring prompt object, so additional attributes selector was failing.