Skip to content

Commit ad33b38

Browse files
authored
[gha] ensure the FreeBSD build job fails when there are compilation failures (#144)
1 parent 67e77f1 commit ad33b38

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,10 @@ jobs:
250250
-G Ninja \
251251
-S ${{ github.workspace }}/SourceCache/ds2
252252
cmake --build ${{ github.workspace }}/BinaryCache/ds2 --config Release
253-
tar -C ${{ github.workspace }}/BinaryCache -cvf ${{ github.workspace }}/BinaryCache/ds2.tar ds2
253+
254+
# Tar the output to preserve permissions.
255+
- name: tar output
256+
run: tar -C ${{ github.workspace }}/BinaryCache -cvf ${{ github.workspace }}/BinaryCache/ds2.tar ds2
254257

255258
- uses: actions/upload-artifact@v4
256259
with:

Sources/Host/FreeBSD/Platform.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ static struct utsname const *GetCachedUTSName() {
3636

3737
char const *Platform::GetOSVersion() { return GetCachedUTSName()->release; }
3838

39-
char const *Platform::GetOSBuild() { return GetCachedUTSName()->version; }
39+
char const *Platform::GetOSBuild() { return GetCachedUTSName()->release; }
4040

41-
char const *Platform::GetOSKernelPath() { return nullptr; }
41+
char const *Platform::GetOSKernelVersion() { return GetCachedUTSName()->version; }
4242

4343
const char *Platform::GetSelfExecutablePath() {
4444
return Host::FreeBSD::ProcStat::GetExecutablePath(getpid()).c_str();

0 commit comments

Comments
 (0)