-
Notifications
You must be signed in to change notification settings - Fork 11
UKBottomModalController and UKCenterModalController #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller; implement their appearance/disapperance
…nt when it is long
VislovIvan
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the implementation of center and bottom modal controllers for UIKit.
Since the behavior and properties of these modals differ based on their position (e.g., the bottom modal can be swiped or dragged vertically), I decided to create separate components rather than have a single one.
Shared Components
ModalVM:A protocol defining the essential properties that all modals must implement.
UKModalController:An abstract base class that cannot be directly initialized outside the library. This class provides the shared functionality and structure for specific modal implementations, serving as a foundation for extension.
Center Modal
CenterModalVM:Implements the
ModalVMprotocol. The center modal does not have additional unique properties, as its functionality is standard.UKCenterModalController:Inherits from
UKModalControllerand adjusts the layout to center the modal's content on the screen.Bottom Modal
BottomModalVM:Implements the
ModalVMprotocol and introduces two specific properties:isDraggable: Determines if the modal can be dragged vertically.hidesOnSwap: Specifies whether the modal should hide when swiped down.UKBottomModalController:Inherits from
UKModalControllerand aligns content to the bottom of the screen. This controller also includes a gesture recognizer, enabling users to drag the modal vertically to adjust its position or dismiss it.Common Features
All modals support three customizable content areas:
The body is wrapped in a content-sized scroll view. This scroll view adjusts its behavior dynamically:
Previews
This PR includes previews for both modal types. Common functionality has been extracted into
ModalPreviewHelpers.