SUCountdown #32
Merged
SUCountdown #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VislovIvan
commented
Dec 9, 2024
VislovIvan
commented
- SwiftUI Countdown
- CountdownVM
- CountdownManager
- Localization
- Documentation
- Preview into App
- SUCountdown - CountdownVM - CountdownManager - added into preview
mikhailChelbaev
requested changes
Dec 9, 2024
Collaborator
mikhailChelbaev
left a comment
mikhailChelbaev
left a comment
There was a problem hiding this comment.
Good in general, but requires some improvement
Also, don't forget to write self., right now you don't have it almost anywhere
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/CountdownPreview.swift
Outdated
Show resolved
Hide resolved
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/CountdownPreview.swift
Outdated
Show resolved
Hide resolved
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/CountdownPreview.swift
Outdated
Show resolved
Hide resolved
- func localizedUnit access fix
- refactored the SUCountdown view, separated each layout style (none, bottom, trailing) - extracted repeated UI components - updated CountdownPreview - localizedUnit bug fix
mikhailChelbaev
requested changes
Dec 12, 2024
Sources/ComponentsKit/Countdown/Localization/UnitsLocalization.swift
Outdated
Show resolved
Hide resolved
Sources/ComponentsKit/Countdown/Localization/UnitsLocalization.swift
Outdated
Show resolved
Hide resolved
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/CountdownPreview.swift
Outdated
Show resolved
Hide resolved
- selectedLocale removed - initializer removed - horizontalPadding removed
"enum Unit" and "enum UnitLength" extracted into a separate file CountdownHelpers
- added 3 base components (timeWithoutUnit, timeWithShortUnit, timeWithLongUnit)
- attributedString for SUCountdown layout - calculateMaxWidth - to do: colonView padding bug
mikhailChelbaev
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.