SUProgressBar #43
Merged
SUProgressBar #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VislovIvan
commented
Dec 24, 2024
VislovIvan
commented
- SUProgressBar
- ProgressBarVM
- Preview into app
- Documentation
mikhailChelbaev
requested changes
Dec 25, 2024
Collaborator
mikhailChelbaev
left a comment
mikhailChelbaev
left a comment
There was a problem hiding this comment.
Good implementation but requires some improvements
Apart from these comments, don't forget to write self. because at the moment it is missing almost everywhere
Sources/ComponentsKit/ProgressBar/Models/ProgressBarStyle.swift
Outdated
Show resolved
Hide resolved
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/ProgressBarPreview.swift
Show resolved
Hide resolved
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/ProgressBarPreview.swift
Outdated
Show resolved
Hide resolved
renamed to progress and moved to the top
bug fix: the stripes are not drawn on the entire area
mikhailChelbaev
requested changes
Dec 30, 2024
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/ProgressBarPreview.swift
Show resolved
Hide resolved
- renamed to innerBarPadding - moved to extension ProgressBarVM
- Corner Radius fix - frame calculation fix
mikhailChelbaev
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.