UKProgressBar #50
Merged
UKProgressBar #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VislovIvan
commented
Dec 30, 2024
VislovIvan
commented
- UKProgressBar
- fix SUProgressBar progress animation (the same animation for the swiftui and uikit components)
- layoutNeedsUpdate to shouldUpdateLayout
mikhailChelbaev
requested changes
Jan 1, 2025
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/ProgressBarPreview.swift
Outdated
Show resolved
Hide resolved
- self.$currentValue
extracted to the model and used for swiftui and uikit
- renamed to updateProgressBar - moved to updateBarWidth
- added func sizeThatFits
- added in model - used for updateProgressBar
added func cornerRadius(forHeight height: CGFloat) -> CGFloat to calculate corner radius
mikhailChelbaev
requested changes
Jan 6, 2025
mikhailChelbaev
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.