Fix breaking layout in Countdown #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VislovIvan
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where the layout of the
Countdowncomponent could break under certain conditions.The issue occurred when the unit text was shorter than the time value. The bug appeared because the cell width was calculated only once on appear and when model changes. However, the width of digits can vary, and as the value changes every second, it could exceed the initially calculated width.
Ideal Solution
The optimal solution would be to recalculate the width dynamically every time the value changes. However, this approach would significantly increase resource usage, which may not be ideal for all devices.
Fix Implemented
To address this, a small value to the initially calculated width is added. While this is not a perfect solution, it should work in most cases. We will monitor this fix, and if the issue appear in the future, we will explore alternative approaches.