improve button #83
Merged
improve button #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VislovIvan
commented
Apr 3, 2025
VislovIvan
commented
- added new parameters (loading and image)
mikhailChelbaev
requested changes
Apr 4, 2025
Collaborator
mikhailChelbaev
left a comment
mikhailChelbaev
left a comment
There was a problem hiding this comment.
Overall, it works well, but there are few bugs, and the code needs some improvements.
Collaborator
There was a problem hiding this comment.
I see why you included all the if conditions, but I think it's better to remove them. This way, people can understand how the parameters interact with each other.
Collaborator
There was a problem hiding this comment.
Also sort the params in alphabetical order
Collaborator
There was a problem hiding this comment.
Add contentSpacing param and a toggle to show / hide the title (similar to the one in alert / modals)
- buttonImage renamed to image
- inactive while loading
mikhailChelbaev
requested changes
Apr 7, 2025
Collaborator
mikhailChelbaev
left a comment
mikhailChelbaev
left a comment
There was a problem hiding this comment.
also a bug: tint color is not applied to local image
Sources/ComponentsKit/Components/Button/Models/ButtonImageSource.swift
Outdated
Show resolved
Hide resolved
- using layout constraints
- moved into shared helpers - duplicated code deleted
mikhailChelbaev
requested changes
Apr 8, 2025
Examples/DemosApp/DemosApp/ComponentsPreview/PreviewPages/ButtonPreview.swift
Show resolved
Hide resolved
- the image view added based on the imagePosition value in the model
mikhailChelbaev
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.