library: Optimize SuperDropdown #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # miuix/src/commonMain/kotlin/top/yukonga/miuix/kmp/extra/SuperDropdown.kt
fix: [SuperDropdown] Limit popup size and margins. update: [SuperDropdown] Popup content padding, rounded corners, font size
Member
|
深色压暗我当时是感觉看不太出来边界所以才改成 0.6f 的，如果改回一样的话就不需要在 MiuixColor 定义了 |
Collaborator
Author
看了下dialog的边界不明显应该是dialog背景颜色问题，dropdown的如果不加选中边界还行，加了选中比较明显，我还在试颜色 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改了 Dropdown popup 内容的边距，字号，最小最大宽度，圆角；
限制 Dropdown popup 的最小最大高度（防止超出屏幕范围）；
加了 Dropdown 销毁时自动关闭 popup （比如旋转屏幕）；
改了 Dropdown 选中时的颜色值（变淡一点）；
改了深色下弹窗的压暗颜色（0.6），改回了米米的 0.3 ；
所有数值改动来自米米的代码