make x-initialSync part of the spec as initial_sync attribute#823
Merged
ndeloof merged 1 commit intocompose-spec:mainfrom Sep 17, 2025
Merged
make x-initialSync part of the spec as initial_sync attribute#823ndeloof merged 1 commit intocompose-spec:mainfrom
ndeloof merged 1 commit intocompose-spec:mainfrom
Conversation
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR formalizes the experimental x-initialSync attribute by promoting it to an official initial_sync attribute in the Compose specification. This attribute ensures initial synchronization is performed before starting watch mode for sync+x triggers.
- Adds
initial_syncas a boolean field to theTriggerstruct - Updates the JSON schema to include the new
initial_syncproperty with proper documentation - Migrates existing test cases from the experimental
x-initialSyncto the newinitial_syncattribute
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| types/develop.go | Adds InitialSync boolean field to the Trigger struct with YAML/JSON tags |
| types/derived.gen.go | Updates the generated deep copy function to include the new InitialSync field |
| schema/compose-spec.json | Adds initial_sync boolean property to the JSON schema with description |
| loader/loader_test.go | Updates test case to use the new initial_sync attribute instead of x-initialSync |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ndeloof
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-initialSyncattribute was there for more than a year as an experimental feature to synchronize host content with services containers whensync+xtriggers are setup, we think it could be now officially part of the specificationCompose Specification PR
See docker/docs#23345