Fix PSR-0 optimized classmap includes classes that do not match the configured namespace prefix #33
Open
skmetaly wants to merge 1 commit intocomposer:mainfrom
Open
Fix PSR-0 optimized classmap includes classes that do not match the configured namespace prefix #33skmetaly wants to merge 1 commit intocomposer:mainfrom
skmetaly wants to merge 1 commit intocomposer:mainfrom
Conversation
skmetaly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Restores the namespace prefix check for PSR-0 inside
filterByNamespace(). This was removed in #8 to enable --strict-psr warnings for non-matching classes, but PSR-0 path computation uses the full class name without stripping the prefix, so the check was the only guard preventing false positive matches.The fix adds the prefix check back inside the PSR-0 if branch only. Non-matching classes are still added to
$rejectedClassesso PSR violation warnings are preserved.PSR-4 is unaffected because it strips the prefix during path computation, so non-matching classes produce wrong paths and are rejected.