Fix some warnings

Seldaek · Seldaek · commit a3801f2dddb8 · 2025-03-24T10:02:33.000+01:00
diff --git a/src/Security/BruteForceLoginFormAuthenticator.php b/src/Security/BruteForceLoginFormAuthenticator.php
@@ -137,7 +137,7 @@ private function getCredentials(Request $request): array
 
         $credentials['username'] = trim($credentials['username']);
 
-        if (\strlen($credentials['username']) > UserBadge::MAX_USERNAME_LENGTH) {
+        if (\strlen($credentials['username']) > UserBadge::MAX_USERNAME_LENGTH || '' === $credentials['username']) {
             throw new BadCredentialsException('Invalid username.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ private function getCredentials(Request $request): array`
`137`	`137`
`138`	`138`	`$credentials['username'] = trim($credentials['username']);`
`139`	`139`
`140`		`- if (\strlen($credentials['username']) > UserBadge::MAX_USERNAME_LENGTH) {`
	`140`	`+ if (\strlen($credentials['username']) > UserBadge::MAX_USERNAME_LENGTH \|\| '' === $credentials['username']) {`
`141`	`141`	`throw new BadCredentialsException('Invalid username.');`
`142`	`142`	`}`
`143`	`143`