Disallow PREG_SET_ORDER in matchAll

Author: Seldaek

src/Preg.php

@@ -26,7 +26,7 @@ class Preg
     public static function match($pattern, $subject, &$matches = null, $flags = 0, $offset = 0)
     {
         if (($flags & PREG_OFFSET_CAPTURE) !== 0) {
-            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the type of $matches');
+            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the type of $matches, use matchWithOffset() instead');
         }
 
         $result = preg_match($pattern, $subject, $matches, $flags, $offset);
@@ -70,7 +70,11 @@ public static function matchWithOffset($pattern, $subject, &$matches = null, $fl
     public static function matchAll($pattern, $subject, &$matches = null, $flags = 0, $offset = 0)
     {
         if (($flags & PREG_OFFSET_CAPTURE) !== 0) {
-            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the type of $matches');
+            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the type of $matches, use matchAllWithOffset() instead');
+        }
+
+        if (($flags & PREG_SET_ORDER) !== 0) {
+            throw new \InvalidArgumentException('PREG_SET_ORDER is not supported as it changes the type of $matches');
         }
 
         $result = preg_match_all($pattern, $subject, $matches, $flags, $offset);

src/Regex.php

@@ -34,7 +34,7 @@ public static function isMatch($pattern, $subject, $offset = 0)
     public static function match($pattern, $subject, $flags = 0, $offset = 0)
     {
         if (($flags & PREG_OFFSET_CAPTURE) !== 0) {
-            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the return type');
+            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the return type, use matchWithOffset() instead');
         }
 
         $count = Preg::match($pattern, $subject, $matches, $flags, $offset);
@@ -68,7 +68,11 @@ public static function matchWithOffset($pattern, $subject, $flags = 0, $offset =
     public static function matchAll($pattern, $subject, $flags = 0, $offset = 0)
     {
         if (($flags & PREG_OFFSET_CAPTURE) !== 0) {
-            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the return type');
+            throw new \InvalidArgumentException('PREG_OFFSET_CAPTURE is not supported as it changes the return type, use matchAllWithOffset() instead');
+        }
+
+        if (($flags & PREG_SET_ORDER) !== 0) {
+            throw new \InvalidArgumentException('PREG_SET_ORDER is not supported as it changes the return type');
         }
 
         $count = Preg::matchAll($pattern, $subject, $matches, $flags, $offset);