Some changes to reduce cpp usage in the Main file.#50
Draft
pranaysashank wants to merge 1 commit intomasterfrom
Draft
Some changes to reduce cpp usage in the Main file.#50pranaysashank wants to merge 1 commit intomasterfrom
pranaysashank wants to merge 1 commit intomasterfrom
Conversation
pranaysashank
force-pushed
the
ghc-module-per-version
branch
3 times, most recently
from
3e986e1 to
0c68bb3
Compare
- Made separate modules for each ghc version in the hopes that maintaining them would become easier than the many nested if, else we have in cpp right now.
pranaysashank
force-pushed
the
ghc-module-per-version
branch
from
0c68bb3 to
0aa9fad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopes that maintaining them would become easier
than the many nested if, else we have in cpp right now.
which seems a bit to hard to eliminate without duplicating
efforts.
In the CI, 8.4.4 fails I don't understand the error messageSo justthere.
module Ain the file is not valid syntax,wonder why I thought it was.
And 9.4.2 needs Debug.Trace but previous versions
don't need it in the imports, where is it coming from?
Opened for CI. Turning it back to draft, after verifying that
this approach makes sense by fixing GhcHead I'll revert it.