exam chronological ordering#65
Merged
yutotakano merged 2 commits intocompsoc-edinburgh:masterfrom Dec 12, 2025
Merged
Conversation
yutotakano
requested changes
Oct 9, 2025
Member
yutotakano
left a comment
There was a problem hiding this comment.
Thanks for the PR! I like the 0.1/0.2/0.3/0.4 idea, but I'm not sure I like adding hardcoded values to these sort keys. I found an interesting function in the Python standard library that maybe we can use, could you look into that?
yutotakano
reviewed
Dec 12, 2025
yutotakano
approved these changes
Dec 12, 2025
Member
yutotakano
left a comment
There was a problem hiding this comment.
Thanks a lot for working through this! Been bugging many people I think, your help is much appreciated.
yutotakano
added a commit
that referenced
this pull request
Jan 23, 2026
Hotfix bug in exam sorting introduced by #65
Member
|
There was a regression introduced by this PR where visiting the FNLP page would crash the backend: Fixed in #74. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified sort_key function to adjust slightly for exam months. the values are small so they don't conflict with year ordering. i don't know if this is a good fix or not