Improve CI deployment to accurately wait for successful rollout#76
Merged
yutotakano merged 2 commits intocompsoc-edinburgh:masterfrom Jan 24, 2026
Merged
Conversation
8eedebf to
3eac491
Compare
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the rollout CI succeeds pretty much instantly since all we do is trigger the rollout and don't check if it was successful. Jobs are unconditionally successful as long as the kubernetes controller is reachable.
This PR improves the CI reporting so that we explicitly check that production has rolled over its source code using
curlandgrepfor the Git commit sha.