Upstream: Fix image permissions & various small frontend issues#79
Merged
yutotakano merged 19 commits intocompsoc-edinburgh:masterfrom Jan 27, 2026
Merged
Conversation
Fix styling of More button in the Nav header Closes #375 See merge request vseth/sip-com-apps/community-solutions!582
…on homepage The hook for using the list of metacategories did not have a cache key, and therefore was freshly fetched for every meta category on the homepage if you were an admin. This fixes the issue.
Fix light mode TopHeader using --mantine-color-anchor instead of parent's color See merge request vseth/sip-com-apps/community-solutions!583
Fix `listmetacategories` being fetched freshly for every metacategory See merge request vseth/sip-com-apps/community-solutions!584
Fix permission issues for image API Closes #394 See merge request vseth/sip-com-apps/community-solutions!586
Fix tab closing due to call to undefined 'close' calling window.close() Closes #391 See merge request vseth/sip-com-apps/community-solutions!587
do not transform mailto links in markdown Closes #360 See merge request vseth/sip-com-apps/community-solutions!500
Fix document list not refreshing when navigating between categories See merge request vseth/sip-com-apps/community-solutions!588
Fix extraneous arrow showing on home page if Meta 2 is empty string See merge request vseth/sip-com-apps/community-solutions!589
Member
Author
|
Merging without reviews assuming full responsibility :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains upstream changes between 2025/11/26 and 2026/01/25.
The specific range is (33e6618, 51a5804], where 33e6618 was the last commit that was merged into BI File Collection as part of #70.
Exhaustive List of Changes
Bug fixes
listmetacategoriesendpoint being fetched excessively on the homepage in admin viewwindow.close()accidentally becausecloeswasn't in scopeThe following commits are also included, but are not relevant to us
I list them here so that it serves as an exhaustive description of all commits that the PR contains when doing git blame etc in the future.
DB Model Changes
Merge
I've done a manual merge with our repo. UTs pass and the frontend looks fine. There are no DB model changes. Thus, if the CI passes, I will merge with full responsibility.