Skip to content

Conversation

@constantinpape
Copy link
Contributor

No description provided.

@constantinpape constantinpape marked this pull request as ready for review April 21, 2025 16:10
@schilling40
Copy link
Contributor

For postprocess_seg.py the creation of a table with _compute_table() in postprocessing.py currently fails because of different lengths of the arrays when creating the dataframe. I will investigate which arrays should be a different length tomorrow. The current implementation of the function only allows the use of a single spatial statistics function, which is probably sufficient without more sophisticated approaches.

@constantinpape
Copy link
Contributor Author

For postprocess_seg.py the creation of a table with _compute_table() in postprocessing.py currently fails because of different lengths of the arrays when creating the dataframe. I will investigate which arrays should be a different length tomorrow.

I went ahead and fixed this and also added a small test. While doing this I noticed that there's one other discrepancy, we can quickly discuss tomorrow.

The current implementation of the function only allows the use of a single spatial statistics function, which is probably sufficient without more sophisticated approaches.

Yeah, I think that's sufficient for now. We can extend this later if necessary.

@schilling40 schilling40 merged commit 6aba946 into master Apr 24, 2025
6 checks passed
@schilling40 schilling40 deleted the refactor-and-linter branch April 28, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants