Skip to content

Conversation

@schilling40
Copy link
Contributor

Functions for post-processing the SGN segmentation of cochleas using erosion with spatial statistics.

WIP

  • edit script for post-processing
  • more flexible spatial statistics

Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, we should add the option for graph connected components, as you already marked down in the TODO

@constantinpape
Copy link
Contributor

Also, I think it would make sense if we order the SGN components by size, so that 1 is always the largest component etc.

@schilling40
Copy link
Contributor Author

The current implementation of the graph connected component analysis seems to have some error.
After post-processing the eroded subset, the connected components of the graph feature nodes, which appear to be further distanced from the main cochlea segmentation when visioned not along the x-axis.
I am still trying to find out the issue and resolve it.

@schilling40
Copy link
Contributor Author

The current implementation of the graph connected component analysis seems to have some error. [...]

The indexing of the 'component_labels' was offset by 1 because of the 'label_id' starting at 1.

Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't fully check the graph component logic, but it makes sense on a quick glance. I pushed a commit to fix the test errors. Anything else to add here from your end @schilling40 ? Otherwise I will merge it.

@schilling40
Copy link
Contributor Author

Looks good. I didn't fully check the graph component logic, but it makes sense on a quick glance. I pushed a commit to fix the test errors. Anything else to add here from your end @schilling40 ? Otherwise I will merge it.

Thanks! From my end, there is nothing to add. I am going ahead and merge it.

@schilling40 schilling40 merged commit 68fba2f into master May 13, 2025
6 checks passed
@constantinpape constantinpape deleted the postprocessing_with_connected_components branch May 13, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants