-
Notifications
You must be signed in to change notification settings - Fork 1
Postprocessing cochlea segmentation using erosion #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
constantinpape
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for now, we should add the option for graph connected components, as you already marked down in the TODO
|
Also, I think it would make sense if we order the SGN components by size, so that 1 is always the largest component etc. |
|
The current implementation of the graph connected component analysis seems to have some error. |
The indexing of the 'component_labels' was offset by 1 because of the 'label_id' starting at 1. |
constantinpape
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I didn't fully check the graph component logic, but it makes sense on a quick glance. I pushed a commit to fix the test errors. Anything else to add here from your end @schilling40 ? Otherwise I will merge it.
Thanks! From my end, there is nothing to add. I am going ahead and merge it. |
Functions for post-processing the SGN segmentation of cochleas using erosion with spatial statistics.
WIP